Introduce Passthrough Response type #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 15, 2020 12:50
|
@jessicayuen This is a POC for conveying my thoughts on #299 . Let me know what you think |
jessicayuen
reviewed
May 15, 2020
added 2 commits
May 15, 2020 14:32
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
jessicayuen
reviewed
May 15, 2020
added 3 commits
May 15, 2020 15:10
jyotimahapatra
changed the title
|
@jessicayuen PTAL. Once it looks good to you, we can ask Kuat to take a look next. |
jessicayuen
reviewed
May 16, 2020
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
|
@kyessenov Please take a look. |
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
|
@kyessenov Let us know what you feel about the change. |
mattklein123
requested changes
May 30, 2020
mattklein123
approved these changes
Jun 2, 2020
This was referenced Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#299
While implementing envoyproxy/xds-relay#85 , we realized that go-control-plane always marshals the response. As a result, we were not able to send an existing DiscoveryResponse as a passthrough.
This PR introduces a new PassthroughResponse struct , which is not subjected to any marshalling while sending the response on the watches.